Skip to content

RK3588 VICAP support

With the work in #34 as prerequisite, we can extend the rkcif driver to bring up the RK3588 VICAP. In order to test these extensions, however, other changes are required as well. Let us consider the following work package

  • Bring up one Radxa 4K Camera with the Radxa ROCK 5B+ based on mainline and stream the raw sensor data into memory.
  • Make nice patches: Add RK3588 support to the CSI DPHY driver + DT magic.
  • Make nice patches: Add RK3588 support to the rkcif driver + DT magic.
  • Add RK3588 documentation.
  • Make nice patches: Add DT overlay for Radxa 4K Camera on port 0 (optionally: on port 1 as well).
  • Initial bring up only worked using one of the two IOMMUs. Find a way to use both IOMMUs.
  • Turns out the bits of the CTRL0 register of each MIPI CSI block are different between RK3568 and RK3588 🙈 Find an elegant way to support both variants.
  • The CSI DPHY driver blocks writes to syscon register offset 0, but this is a valid case in the RK3588 variant (in fact, there is only access to offset 0). Find an elegant way to support both ways.
  • The CSI-2 receiver features interrupts for error reporting. Quite useful for debugging, but not sure what should happen to them in the productive case. Clean up the hacks and maybe issue some dev_dbg prints.
  • The IMX415 driver requires a certain clock name despite what the dt binding says... Remove the comment in the overlay and sort this issue out.
  • Revise the patch that sets the correct pinctrl for the I2C buses: there are different base dtsi's for the vast amount of ROCK5 board variants. Find the correct one.
  • Hope for the best (i.e. that the nice patches will be accepted soon :-))

Patch series in flight:

  • RK3588 MIPI CSI-2 DPHY changes: PATCH v2
    • In v3 (if any) correct "false negatives" -> "false positives" 🙈
    • Move anyOf block after required (krzk)
    • Improve commit message and description of apb reset, but leave phy reset name as is (krzk)
    • Fix patch so that mipicdphy1 remains disabled
  • RK3588 VICAP support: to be submitted once #34 is completed
Edited by Michael Riesch